Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In place batch_norm #9420

Merged
merged 2 commits into from
Mar 28, 2018
Merged

In place batch_norm #9420

merged 2 commits into from
Mar 28, 2018

Conversation

tonyyang-svail
Copy link

fix #9416

  1. add in-place attr to bn
  2. make batch norm in-place in img_conv_group by default

@jacquesqiao
Copy link
Member

jacquesqiao commented Mar 28, 2018 •
edited
Loading

Have you verified the correctness of inplace for batch_nrom? I looked at the code and think it has no problem.
This article says it verified the correctness https://blog.csdn.net/nus_cs/article/details/78126804.

jacquesqiao
jacquesqiao approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

reyoung
reyoung approved these changes Mar 28, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the final solution for inplace. Just a hot fix for conv_bn_pool

@reyoung reyoung merged commit 47e4afb into PaddlePaddle:develop Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@reyoung reyoung reyoung approved these changes

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-place Operations
3 participants
@tonyyang-svail @jacquesqiao @reyoung