Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine cast op #8923

Merged
merged 8 commits into from
Mar 9, 2018
Merged

Refine cast op #8923

merged 8 commits into from
Mar 9, 2018

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Mar 9, 2018 •
edited
Loading

Fix #8924

@QiJune QiJune requested a review from jacquesqiao March 9, 2018 07:50
jacquesqiao
jacquesqiao previously approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacquesqiao
jacquesqiao approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QiJune QiJune merged commit b341bac into PaddlePaddle:develop Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QiJune @jacquesqiao