Fix the model in test_machine_translation.py. #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
requested changes
Jan 24, 2018
| size=hidden_size * 4, | ||
| act='tanh', | ||
| bias_attr=True) | ||
| reversed, _ = fluid.layers.dynamic_lstm( |
| size=hidden_size * 4, | ||
| is_reverse=True, | ||
| use_peepholes=USE_PEEPHOLES) | ||
| return forward, reversed |
| def bi_lstm_encoder(input_seq, hidden_size): | ||
| input_forward_proj = fluid.layers.fc(input=input_seq, | ||
| size=hidden_size * 4, | ||
| act='tanh', |
There was a problem hiding this comment.
这里的fc 是下图红色计算，为什么要加 tanh 呢？
| use_peepholes=USE_PEEPHOLES) | ||
| input_reversed_proj = fluid.layers.fc(input=input_seq, | ||
| size=hidden_size * 4, | ||
| act='tanh', |
|
|
||
|
|
||
| def lstm_step(x_t, hidden_t_prev, cell_t_prev, size): | ||
| def linear(inputs): |
There was a problem hiding this comment.
加一个 fixme 的comment， replace this function with the lstm_unit_op.
| encoded_vector = fluid.layers.concat( | ||
| input=[src_forward, src_reversed], axis=1) | ||
|
|
||
| context = fluid.layers.sequence_pool(input=encoded_vector, pool_type='last') |
There was a problem hiding this comment.
请确认一下现在op的逻辑，reverse的时候是否要取first 而不是last。
There was a problem hiding this comment.
已确认，reverse时也是取last。
peterzhang2029
force-pushed
the
nmt_fix
branch
from
958bf0e to
d6e06d3
Compare
peterzhang2029
force-pushed
the
nmt_fix
branch
from
d6e06d3 to
beb9075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #7012