Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ExternalProject_Add to download and install boost. #7707

Merged
merged 10 commits into from
Jan 24, 2018
Merged

Use ExternalProject_Add to download and install boost. #7707

merged 10 commits into from
Jan 24, 2018

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Jan 20, 2018 •
edited
Loading

Fix #7708

It is not time-consuming to download, build and install boost by ExternalProject_Add in CMake when I test on my server.

@qingqing01 qingqing01 force-pushed the boost_cmake branch 2 times, most recently from c1283c0 to a699d20 Compare January 20, 2018 12:38
typhoonzero
typhoonzero reviewed Jan 22, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems boost building command ./b2 install is generating too much logs, can you make boost build quiet please?

@qingqing01
Copy link
Contributor Author

qingqing01 commented Jan 22, 2018 •
edited
Loading

@typhoonzero

  • In Fluid, we only depend on the header file of boost, so only add --with-program_options in installing step. Do you think is it ok?
  • For the logs, I'll make boost build quiet. Thanks.

@typhoonzero
Copy link
Contributor

In Fluid, we only depend on the header file, so only add --with-program_options in installing step. Do you think is it ok?

I did some search and it seems that program_options is only one part of the boost libraries that do argument parsing, for paddle we use gflags currently maybe it's not needed? I'm not sure you can have some test, if you are testing with docker, try remove the boost installation inside the docker, and maybe the Dockerfile under current repo should also be updated.

The build options of boost: https://theboostcpplibraries.com/introduction-installation
Maybe you are looking for --build-type?

@reyoung
Copy link
Collaborator

reyoung commented Jan 22, 2018

Paddle does not use any boost library. It is no need to build boost.

Just adding the include_directories is enough

@typhoonzero
Copy link
Contributor

@reyoung was right, download boost and add to include_directories is enough, please ignore my comments.

@qingqing01
Copy link
Contributor Author

@typhoonzero @reyoung Thanks!

reyoung
reyoung previously approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

typhoonzero
typhoonzero approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingqing01 qingqing01 merged commit 114d0c1 into PaddlePaddle:develop Jan 24, 2018
@qingqing01 qingqing01 deleted the boost_cmake branch November 14, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@reyoung reyoung reyoung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingqing01 @typhoonzero @reyoung