Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update switch kernel documentation #7597

Merged
merged 3 commits into from
Jan 19, 2018
Merged

update switch kernel documentation #7597

merged 3 commits into from
Jan 19, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jan 17, 2018 •
edited
Loading

project: #7589
fix: #7628

@jacquesqiao jacquesqiao mentioned this pull request Jan 17, 2018
Closed
6 tasks
wangkuiyi
wangkuiyi requested changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an issue, in addition to the project mentioned in this PR, to explain what we are doing in this PR. Or, at least make the title of this PR readable -- it says "update switch kernel", but it's actually updating the documentation?

@jacquesqiao jacquesqiao changed the title Update switch kernel update switch kernel documentation Jan 18, 2018
@jacquesqiao
Copy link
Member Author

@wangkuiyi issue has been created and updated~ Thank you for your reminding!

@wangkuiyi wangkuiyi merged commit 7e4cbfe into PaddlePaddle:develop Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@reyoung reyoung reyoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update switch kernel documentation
3 participants
@jacquesqiao @reyoung @wangkuiyi