Add pyton wrapper for row conv operator. #7575
Conversation
… fix-7555 Conflicts: doc/api/v2/fluid/layers.rst python/paddle/v2/fluid/layers/nn.py
python/paddle/v2/fluid/layers/nn.py
Outdated
|
|
||
| Args: | ||
| input (Variable): Input variable, a 2D LoDTensor with shape [T, D]. | ||
| future_context_size (int): Future context size. |
There was a problem hiding this comment.
Better to give example, assumed future_context_size = 2, the context size of convolution is 3 ....
| """ | ||
| helper = LayerHelper('row_conv', **locals()) | ||
| dtype = helper.input_dtype() | ||
| filter_shape = [future_context_size + 1, input.shape[1]] |
There was a problem hiding this comment.
Better to check the input.shape.size.
There was a problem hiding this comment.
It seems the exception information is informational enough.
python/paddle/v2/fluid/layers/nn.py
Outdated
| In the above equation: | ||
|
|
||
| * :math:`Out_{i}`: The i-th row of output variable with shape [1, D]. | ||
| * :math:`\\tau`: Future context size. Please note, the shape of |
There was a problem hiding this comment.
Quick clarification: The value of
There was a problem hiding this comment.
Yeah, actually i was concerned about the wording in your doc: ":math:\\tau: Future context size."
There was a problem hiding this comment.
Sorry for this minor and maybe frustrating comment, but I think if
Maybe I misunderstood something?
There was a problem hiding this comment.
I think it is correct, we execute future context size + 1 times of sum operations.
There was a problem hiding this comment.
The range of j is [i, \tau + i]. Should be executed
python/paddle/v2/fluid/layers/nn.py
Outdated
| """Row Conv Operator. This layer will apply lookahead convolution to | ||
| **input**. The input variable should be a 2D LoDTensor with shape [T, D]. | ||
| Parameters with shape [future_context_size + 1, D] will be created. The math | ||
| equation of row convolution is as following: |
There was a problem hiding this comment.
Minor typo: following -> follows
… fix-7555 Conflicts: python/paddle/v2/fluid/layers/nn.py
… fix-7555 Conflicts: python/paddle/v2/fluid/layers/nn.py python/paddle/v2/fluid/tests/test_layers.py
Resolves #7555