fix grpc client get variable #7573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
requested changes
Jan 17, 2018
| @@ -63,9 +63,6 @@ bool RPCClient::AsyncGetVariable(const std::string& ep, | |||
| sendrecv::VariableMessage req; | |||
| req.set_varname(var_name); | |||
|
|
|||
| auto* var = scope.FindVar(var_name); | |||
There was a problem hiding this comment.
We need an issue explaining why would we remove these two lines. Or, at least explain the reason in the description of this PR, so could we record the reasoning behind the change.
There was a problem hiding this comment.
Added the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7631
Fix GRPC client get variable before it's initialized.