Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inference]Fix PaddleX model bugs when convert to pir-trt (Part2) #69885

Merged
merged 7 commits into from
Dec 10, 2024
Merged

[Inference]Fix PaddleX model bugs when convert to pir-trt (Part2) #69885

merged 7 commits into from
Dec 10, 2024
+77 −130

Conversation

YuanRisheng
Copy link
Contributor

@YuanRisheng YuanRisheng commented Dec 2, 2024 •
edited
Loading

PR Category

Inference

PR Types

Bug fixes

Description

card-71500
本PR修了如下bug：

  • 修复pir-trt在分割模型下运行期分配内存导致的耗时问题
  • tensorrt_engine_instruction代码简化，删除低版本TRT适配代码
  • 完善机制支持optional输入进行convert场景
  • 优化trt engine本地序列化命名规则，解决运行时执行engine混乱问题
  • 优化full converter中输出类型选择逻辑
  • 工具类函数功能完善，trt_reduce_to_scalar支持传入转换类型，get_shape_tensor_element适配0维Tensor场景
  • nearest_interp_converter逻辑重构，删除冗余代码，修复逻辑问题
  • bilinear_interp_converter问题修复，解决添加add_shape层后无法正常获取shape的问题
  • arange_converter逻辑优化，修复fill_layer输入类型不一致问题
  • full_with_tensor_converter适配0维Tensor场景

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 2, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

lizexu123
lizexu123 reviewed Dec 9, 2024
View reviewed changes
paddle/fluid/framework/new_executor/instruction/tensorrt_engine_instruction.cc
@@ -812,6 +759,13 @@ void TensorRTEngineInstruction::RunTrt() {
}

void TensorRTEngineInstruction::Run() {
#if IS_TRT_VERSION_LT(8500)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉加这一句，对应Marker得改好多东西

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker不是必须要改的吧

@lizexu123
Copy link
Contributor

lizexu123 commented Dec 9, 2024 via email

@YuanRisheng
Copy link
Contributor Author

之前有限制8.5以下版本的 发自我的iPhone
…
------------------ Original ------------------ From: YuanRisheng @.> Date: Mon,Dec 9,2024 7:39 PM To: PaddlePaddle/Paddle @.> Cc: lizexu123 @.>, Comment @.> Subject: Re: [PaddlePaddle/Paddle] [Inference]Fix PaddleX model bugs whenconvert to pir-trt (Part2) (PR #69885)

我们pir-trt以后不支持8.5以下版本了

vivienfanghuagood
vivienfanghuagood approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@vivienfanghuagood vivienfanghuagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangbo9674
zhangbo9674 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 0f66ede into PaddlePaddle:develop Dec 10, 2024
27 of 28 checks passed
@tianshuo78520a tianshuo78520a mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizexu123 lizexu123 lizexu123 left review comments

@vivienfanghuagood vivienfanghuagood vivienfanghuagood approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuanRisheng @lizexu123 @XieYunshen @zhangbo9674 @vivienfanghuagood