[Kernel] Optimize p_norm gpu #69660
Merged
[Kernel] Optimize p_norm gpu #69660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
approved these changes
Nov 25, 2024
| phi::funcs::ElementwiseKernel<T>( | ||
| dev_ctx, ins, &outs, UnsignedPowFunctor<T>(1. / porder)); | ||
| if (porder != 1.0) { | ||
| // save computation when porder is 1.0 |
There was a problem hiding this comment.
porder is 1.0的描述和判断条件 porder != 1.0 不太对应
There was a problem hiding this comment.
porder is 1.0的描述和判断条件porder != 1.0不太对应
代码上应该是没问题的，1.0的时候不用跑下面的幂运算，注释我后续移动到上面去
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Performance Optimization
PR Types
Improvements
Description
Pcard-75624
针对p=1/2/3的case，优化
p_norm的 GPU functor优化前
优化后
耗时减少比例