[Typing][C-132,C-133,C-134] Add type annotations for python/paddle/nn/{clip,decode,initializer/lazy_init}.py
#67031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Aug 6, 2024
| @@ -129,5 +133,5 @@ def __enter__(self): | |||
| """ | |||
| lazy_init_helper().enable() | |||
|
|
|||
| def __exit__(self, *args, **kwargs): | |||
| def __exit__(self, *args: object, **kwargs: Any) -> None: | |||
There was a problem hiding this comment.
这俩为啥一个 object 一个 Any
这里可以改成 __exit__ 的标准签名么 https://stackoverflow.com/questions/58808055/what-are-the-python-builtin-exit-argument-types
There was a problem hiding this comment.
这俩为啥一个
object一个Any
我也想知道啊 ... ...
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1
- files were modified by this hook
Found 1 error (1 fixed, 0 remaining).
这里可以改成
__exit__的标准签名么 https://stackoverflow.com/questions/58808055/what-are-the-python-builtin-exit-argument-types
我改一下吧，看看有木有问题 ～
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
python/paddle/nn/clip.pypython/paddle/nn/decode.pypython/paddle/nn/initializer/lazy_init.pyRelated links
@SigureMo @megemini