[Typing][B-41,B-48][BUAA] Add type annotations for python/paddle/autograd/ir_backward.py,python/paddle/cost_model/cost_model.py
#66890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luohongzhige
requested review from
Aurelius84,
cxxly,
xiaoguoguo626807 and
changeyoung98
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
Luohongzhige
changed the title
python/paddle/autograd/ir_backward.py,python/paddle/cost_model/cost_model.pypython/paddle/autograd/ir_backward.py,python/paddle/cost_model/cost_model.py
megemini
reviewed
Aug 7, 2024
| inputs: Value | Sequence[Value], | ||
| grad_outputs: Value | Sequence[Value | None] | None = None, | ||
| no_grad_set: set[Value] | None = None, | ||
| ) -> dict[Value, list[Value]]: |
There was a problem hiding this comment.
Suggested change
| ) -> dict[Value, list[Value]]: | |
| ) -> ValueDict: |
| if TYPE_CHECKING: | ||
| from typing import Sequence | ||
|
|
||
| from paddle.base.libpaddle.pir import Value |
There was a problem hiding this comment.
Suggested change
| from paddle.base.libpaddle.pir import Value | |
| from paddle.pir import Value |
| inputs: Value | Sequence[Value], | ||
| grad_outputs: Value | Sequence[Value | None] | None = None, | ||
| no_grad_set: set[Value] | None = None, | ||
| ) -> list[Value]: |
There was a problem hiding this comment.
Suggested change
| ) -> list[Value]: | |
| ) -> list[Value | None]: |
| only_inputs: bool | None = True, | ||
| allow_unused: bool | None = False, | ||
| no_grad_vars: Value | Sequence[Value] | None = None, | ||
| ) -> list[Value]: |
There was a problem hiding this comment.
Suggested change
| ) -> list[Value]: | |
| ) -> list[Value | None]: |
| create_graph: bool | None = False, | ||
| only_inputs: bool | None = True, | ||
| allow_unused: bool | None = False, | ||
| no_grad_vars: Value | Sequence[Value] | None = None, |
There was a problem hiding this comment.
Suggested change
| no_grad_vars: Value | Sequence[Value] | None = None, | |
| no_grad_vars: Value | Sequence[Value] | set[Value] | None = None, |
| if TYPE_CHECKING: | ||
| from paddle.base.compiler import CompiledProgram | ||
| from paddle.base.framework import Program | ||
|
|
||
|
|
||
| class CostModel: | ||
| def __init__(self): |
There was a problem hiding this comment.
Suggested change
| def __init__(self): | |
| def __init__(self) -> None: |
| startup_program: Program | CompiledProgram, | ||
| main_program: Program | CompiledProgram, | ||
| device: str = 'gpu', | ||
| fetch_cost_list: Sequence = ['time'], |
There was a problem hiding this comment.
Suggested change
| fetch_cost_list: Sequence = ['time'], | |
| fetch_cost_list: Sequence[???] = ['time'], |
|
|
||
| import json | ||
| import os | ||
| from typing import TYPE_CHECKING, Sequence |
There was a problem hiding this comment.
从 collections.abc 导入 Sequence
| @@ -59,6 +60,11 @@ | |||
| """ | |||
| __all__ = ['grad', 'calc_gradient', 'calc_gradient_helper'] | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import Sequence | |||
|
@Luohongzhige 请按照 PR 模板提交，不然 tracking issue 跟踪不到，无法 review ~ |
|
关联 #65008 |
已修改 |
SigureMo
reviewed
Aug 12, 2024
Comment on lines
63
to
66
| if TYPE_CHECKING: | ||
| from collections.abc import Sequence | ||
|
|
||
| from paddle.pir import Value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
#65008
B-41,B-48