[Typing][C-121,C-122,C-123,C-124] Add type annotations for python/paddle/quantization/{base_observer,factory,ptq,qat}.py
#66693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 29, 2024
SigureMo
reviewed
Jul 30, 2024
| @@ -73,7 +80,7 @@ def _instance(self, layer: Layer) -> BaseQuanter: | |||
| ObserverFactory = QuanterFactory | |||
|
|
|||
|
|
|||
| def quanter(class_name): | |||
| def quanter(class_name: str) -> BaseQuanter: | |||
| r""" | |||
There was a problem hiding this comment.
2024-07-29 18:07:11 ----------------Check results--------------------
2024-07-29 18:07:11 paddle.quantization.quanter:1
2024-07-29 18:07:11 <string>:10:11: error: Name "CustomizedQuanter" is not defined [name-defined]
2024-07-29 18:07:11 <string>:11:35: error: Argument "activation" to "QuantConfig" has incompatible type "Callable[[str], BaseQuanter]"; expected "QuanterFactory" [arg-type]
2024-07-29 18:07:11 <string>:11:51: error: Argument "weight" to "QuantConfig" has incompatible type "Callable[[str], BaseQuanter]"; expected "QuanterFactory" [arg-type]
2024-07-29 18:07:11 Found 3 errors in 1 file (checked 1 source file)
2024-07-29 18:07:11
2024-07-29 18:07:11
2024-07-29 18:07:11 >>> Mistakes found in type checking!
2024-07-29 18:07:11 >>> Please recheck the type annotations. Run `tools/type_checking.py` to check the typing issues:
2024-07-29 18:07:11 > python tools/type_checking.py paddle.quantization.quanter
2024-07-29 18:07:11 ----------------End of the Check--------------------
这示例代码看样子本来就不能跑，直接在最前面加个 # type: ignore 吧，在 # doctest: +SKIP('need 2 file to run example') 下一行单独写一行
There was a problem hiding this comment.
收到，我看其他都是加在 # doctest: +SKIP('xxxxxxx') 上面来着？
There was a problem hiding this comment.
# type: ignore 和 # doctest: +SKIP('xxxxxxx') 互不影响，前者是应对 type checking ，后者是应对 example code running check ～ 注意一下，针对整段代码，都需要独占一行 ～
Lans1ot
pushed a commit
to Lans1ot/Paddle
that referenced
this pull request
Aug 5, 2024
…ddle/quantization/{base_observer,factory,ptq,qat}.py` (PaddlePaddle#66693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
C-121,C-122,C-123,C-124