[Typing][B-42][BUAA] Add type annotations for python/paddle/autograd/py_layer.py
#66328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 23, 2024
python/paddle/autograd/py_layer.py
Outdated
| @@ -52,7 +59,7 @@ class PyLayerContext: | |||
| ... return grad | |||
| """ | |||
|
|
|||
| def save_for_backward(self, *tensors): | |||
| def save_for_backward(self, *tensors: list[Tensor]) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def save_for_backward(self, *tensors: list[Tensor]) -> None: | |
| def save_for_backward(self, *tensors: Tensor) -> None: |
python/paddle/autograd/py_layer.py
Outdated
| @@ -90,7 +97,7 @@ def save_for_backward(self, *tensors): | |||
| """ | |||
| self.container = tensors | |||
|
|
|||
| def saved_tensor(self): | |||
| def saved_tensor(self) -> list[Tensor] | None: | |||
There was a problem hiding this comment.
Suggested change
| def saved_tensor(self) -> list[Tensor] | None: | |
| def saved_tensor(self) -> tuple[Tensor, ...]: |
python/paddle/autograd/py_layer.py
Outdated
| @@ -122,7 +129,7 @@ def saved_tensor(self): | |||
| """ | |||
| return self.container | |||
|
|
|||
| def mark_not_inplace(self, *args): | |||
| def mark_not_inplace(self, *args: tuple) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def mark_not_inplace(self, *args: tuple) -> None: | |
| def mark_not_inplace(self, *args: Tensor) -> None: |
python/paddle/autograd/py_layer.py
Outdated
| @@ -163,7 +170,7 @@ def mark_not_inplace(self, *args): | |||
| """ | |||
| self.not_inplace_tensors = args | |||
|
|
|||
| def mark_non_differentiable(self, *args): | |||
| def mark_non_differentiable(self, *args: tuple) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def mark_non_differentiable(self, *args: tuple) -> None: | |
| def mark_non_differentiable(self, *args: Tensor) -> None: |
python/paddle/autograd/py_layer.py
Outdated
| @@ -203,7 +210,7 @@ def mark_non_differentiable(self, *args): | |||
| """ | |||
| self.non_differentiable = args | |||
|
|
|||
| def set_materialize_grads(self, value: bool): | |||
| def set_materialize_grads(self, value: bool = True) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def set_materialize_grads(self, value: bool = True) -> None: | |
| def set_materialize_grads(self, value: bool) -> None: |
不要随便增加或修改默认值 ～
python/paddle/autograd/py_layer.py
Outdated
| @@ -322,7 +329,7 @@ class PyLayer(with_metaclass(PyLayerMeta, core.eager.PyLayer, PyLayerContext)): | |||
| """ | |||
|
|
|||
| @staticmethod | |||
| def forward(ctx, *args, **kwargs): | |||
| def forward(ctx, *args: tuple, **kwargs: dict) -> Tensor | list[Tensor]: | |||
There was a problem hiding this comment.
Suggested change
| def forward(ctx, *args: tuple, **kwargs: dict) -> Tensor | list[Tensor]: | |
| def forward(ctx: PyLayerContext, *args: Any, **kwargs: Any) -> Tensor | Sequence[Tensor]: |
python/paddle/autograd/py_layer.py
Outdated
| @@ -361,7 +368,7 @@ def forward(ctx, *args, **kwargs): | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def backward(ctx, *args): | |||
| def backward(ctx, *args: tuple) -> Tensor | list[Tensor]: | |||
There was a problem hiding this comment.
Suggested change
| def backward(ctx, *args: tuple) -> Tensor | list[Tensor]: | |
| def backward(ctx: PyLayerContext, *args: Any) -> Tensor | Sequence[Tensor]: |
SigureMo
changed the title
python/paddle/autograd/py_layer.py
|
有问题可以说，为什么把我的修改覆盖了？ |
抱歉抱歉，是我对git操作还不够熟练，可能无意中给覆盖了，下次一定注意 |
收到，感谢 |
Dale1314
pushed a commit
to Dale1314/Paddle
that referenced
this pull request
Jul 28, 2024
44 tasks
inaomIIsfarell
pushed a commit
to inaomIIsfarell/Paddle
that referenced
this pull request
Jul 31, 2024
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
python/paddle/autograd/py_layer.py
Related links
#65008
@SigureMo @megemini