[Typing][B-29] Add type annotations for python/paddle/distribution/variable.py
#65620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 2, 2024
| import paddle | ||
| from paddle.distribution import constraint | ||
|
|
||
| if TYPE_CHECKING: | ||
| from constraint import Constraint |
There was a problem hiding this comment.
不能这样导入的 ～ 需要用 from paddle.distribution.constraint import Constraint 或者 from .constraint import Constraint ～
| @@ -81,22 +95,22 @@ def constraint(self, value): | |||
|
|
|||
|
|
|||
| class Stack(Variable): | |||
| def __init__(self, vars, axis=0): | |||
| def __init__(self, vars, axis: int = 0) -> None: | |||
SigureMo
reviewed
Jul 2, 2024
| return self._event_rank | ||
|
|
||
| def constraint(self, value): | ||
| def constraint(self, value: Tensor) -> Tensor: | ||
| """Check whether the 'value' meet the constraint conditions of this | ||
| random variable.""" | ||
| return self._constraint(value) |
There was a problem hiding this comment.
这里加一个 assert self._constrant is not None 吧，这里很奇怪为啥要给 constraint 设置 None 的默认值
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description