[Typing][A-73,A-77] Add type annotations for some vision models (AlexNet, LeNet)
#65283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jun 19, 2024
Comment on lines
40
to
48
| input_channels: int, | ||
| output_channels: int, | ||
| filter_size: int | list[int] | tuple[int], | ||
| stride: int | str | tuple[int] | list[int], | ||
| padding: int | list[int] | tuple[int], | ||
| stdv: float, | ||
| groups: int = 1, | ||
| act: str | None = None, | ||
| ) -> None: |
There was a problem hiding this comment.
_typing 模块里面有 SizeXX 可以尝试一下 ～
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
不不 ～～ python/paddle/_typing/shape.py 里面有 Size1 Size2 Size3 ... 可以用作 filter_size ～～～
SigureMo
changed the title
python/paddle/vision/models/*.pyAlexNet, LeNet)
SigureMo
reviewed
Jun 20, 2024
SigureMo
reviewed
Jun 20, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini