[Typing][A-3] Add type annotations for paddle/tensor/creation.py
#65082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 12, 2024
python/paddle/tensor/creation.py
Outdated
| """ | ||
| This function creates a new tensor variable with value in the global block(block 0). | ||
|
|
||
| Args: | ||
| shape (list[int]|tuple[int]): Shape of the variable | ||
| shape (ShapeLike): Shape of the variable |
python/paddle/tensor/creation.py
Outdated
| @@ -2921,14 +3034,16 @@ def polar(abs, angle, name=None): | |||
|
|
|||
|
|
|||
| @dygraph_only | |||
| def cauchy_(x, loc=0, scale=1, name=None): | |||
| def cauchy_( | |||
| x: paddle.Tensor, loc=0, scale=1, name: str | None = None | |||
python/paddle/tensor/creation.py
Outdated
| @@ -2955,14 +3070,16 @@ def cauchy_(x, loc=0, scale=1, name=None): | |||
|
|
|||
|
|
|||
| @dygraph_only | |||
| def geometric_(x, probs, name=None): | |||
| def geometric_( | |||
| x: paddle.Tensor, probs, name: str | None = None | |||
Co-authored-by: Nyakku Shigure <[email protected]>
Co-authored-by: Nyakku Shigure <[email protected]>
Co-authored-by: Nyakku Shigure <[email protected]>
SigureMo
reviewed
Jun 12, 2024
SigureMo
reviewed
Jun 12, 2024
python/paddle/tensor/creation.py
Outdated
| @@ -1079,7 +1134,9 @@ def ones_like(x, dtype=None, name=None): | |||
| return full_like(x=x, fill_value=1, dtype=dtype, name=name) | |||
|
|
|||
|
|
|||
| def zeros(shape, dtype=None, name=None): | |||
| def zeros( | |||
| shape: ShapeLike, dtype: DTypeLike | None = None, name: str | None = None | |||
There was a problem hiding this comment.
2024-06-13 00:06:49 paddle.zeros:1
2024-06-13 00:06:49 <string>:8:28: error: Argument "shape" to "zeros" has incompatible type "List[Tensor]"; expected "Union[Tuple[int, ...], List[int], Tensor]" [arg-type]
看样子是动态 shape 挂了，这里可以不改，直接这样就好，我们改一下 ShapeLike
-DynamicShapeLike: TypeAlias = Union[
+_DynamicShapeLike: TypeAlias = Union[
- Tuple[Union[int, "Tensor", None], ...],
- List[Union[int, "Tensor", None]],
+ Sequence[Union[int, "Tensor", None]],
"Tensor",
]
-ShapeLike: TypeAlias = Union[
+_StaticShapeLike: TypeAlias = Union[
- Tuple[int, ...],
- List[int],
+ Sequence[int],
"Tensor",
]
+ShapeLike: TypeAlias = Union[_DynamicShapeLike, _StaticShapeLike]非 dynamic 的情况基本是没有意义的
SigureMo
reviewed
Jun 13, 2024
python/paddle/tensor/creation.py
Outdated
| @@ -1136,7 +1137,9 @@ def ones_like( | |||
|
|
|||
|
|
|||
| def zeros( | |||
| shape: ShapeLike, dtype: DTypeLike | None = None, name: str | None = None | |||
| shape: DynamicShapeLike, | |||
|
Static Check 结果需要看一下， |
megemini
reviewed
Jun 14, 2024
python/paddle/tensor/creation.py
Outdated
| >>> array = np.array([[1, 1], | ||
| ... [3, 4], | ||
| ... [1, 3]]).astype(np.int64) | ||
| >>> array: npt.NDArray[Any] = np.array([[1, 1], [3, 4], [1, 3]]).astype( |
There was a problem hiding this comment.
这里还是加 # type: ignore 吧 ～ 不然一个简单的例子搞这么复杂，不太友好 ～
@SigureMo 看看行不？后面可以一块儿清理 ～
PaddlePaddle/docs#6680 用来处理渲染的问题 ～
This reverts commit aec0894.
SigureMo
previously approved these changes
Jun 14, 2024
|
@megemini 有一个奇怪的问题，使用 确认只有多进程才会有这个问题，感觉有点奇怪，目前只有这个 API 遇到了，可以低优看看 |
This was referenced Jun 15, 2024
我这里确实没遇到 type checking 的时候抛段错误 ～ 我先记一下吧，关联 #65190 (comment) |
|
啊……还是冲突了，可以解决一下，应该恢复相关文件的修改就可以了～ |
|
啊 我来搞一下吧 |
SigureMo
approved these changes
Jun 16, 2024
tianshuo78520a
approved these changes
Jun 17, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
…addlePaddle#65082) --------- Co-authored-by: Nyakku Shigure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
@megemini
Related links