Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.255】nop #64747

Closed
wants to merge 7 commits into from

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented May 30, 2024

PR Category

Others

PR Types

Others

Description

迁移 nop

image
字段定义变化

测试用例中X, out不是数组 test/deprecated/ir/pir/translator/test_nop_translator.py
image

static_ops.yaml中定义同样不是数组
image

Copy link

paddle-bot bot commented May 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 30, 2024
@co63oc co63oc changed the title CI测试不review 【Hackathon 6th Fundable Projects 3 No.255】nop May 31, 2024
@@ -3042,6 +3042,16 @@
data_type: condition
interfaces : paddle::dialect::InferSymbolicShapeInterface

- op : nop
Copy link
Contributor

@zyfncg zyfncg Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

从描述上看x与out不像是inplace关系,如果不是inplace关系的话也就不符合动态图的处理流程,这里再确认下吧

Copy link
Contributor Author

@co63oc co63oc Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已取消inplace配置,以后如果可以再增加

@co63oc co63oc closed this Jun 15, 2024
@co63oc co63oc deleted the fix_nop branch June 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants