[CINN] Fix gs op transform rules #64655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
May 28, 2024
| rewriter.EraseOp(cloned_op); | ||
| } | ||
|
|
||
| ir_mapping.Add(cloned_op->result(0), out_replacement.value()); |
There was a problem hiding this comment.
cloned_op还没有被使用的话是不是也不需要加mapping了？
Aurelius84
previously approved these changes
May 28, 2024
zyfncg
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-67164
Fix gs op transform rules
原来的转换过程中，gs op转换后的对应shape op没有使用ir mapping里的对应value，而是使用了原始fusion op内前置op的输出。本PR修复这一问题