[CINN] Add constraint for while op #64385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
phlrain
approved these changes
May 17, 2024
tc20042008
approved these changes
May 17, 2024
Comment on lines
+692
to
+696
| if (yield_value_shape[j] == | ||
| builder.Broadcast(input_arg_shape[j], | ||
| original_input_shape[j]) || | ||
| yield_value_shape[j] == builder.Broadcast(original_input_shape[j], | ||
| input_arg_shape[j])) { |
There was a problem hiding this comment.
按照约定。这个if的判断有点复杂了。使用lambda提炼一下，lambda变量名承载注释信息。
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 18, 2024
* add constraint for while of * fix bug
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 19, 2024
* add constraint for while of * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Devs
Description
Pcard-67164
为while op添加符号约束信息。