【Hackathon 6th No.10】Update paddle.searchsorted -part #64331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
reviewed
May 23, 2024
| out_data_[idx] = seq_size_; | ||
| } else { | ||
| if (right_) { | ||
| out_data_[idx] = static_cast<OutType>(phi::funcs::UpperBound<T1, T2>( | ||
| sequence_ptr, seq_size_, *value_ptr)); | ||
| out_data_[idx] = static_cast<OutType>( |
There was a problem hiding this comment.
用 paddle/phi/kernels/funcs/algorithm.h中实现的phi::funcs::UpperBound是有什么问题么？
There was a problem hiding this comment.
paddle/phi/kernels/funcs/algorithm.h 中的 phi::funcs::UpperBound 和 LowerBound 不能直接支持 phi::dtype::float16 和 phi::dtype::bfloat16 吧，需要转一下类型
luotao1
approved these changes
May 23, 2024
|
对应修改下中文文档 |
好的 |
chen2016013
pushed a commit
to chen2016013/Paddle
that referenced
this pull request
May 26, 2024
…4331) * update searchsorted * fix impl * fix impl dtype * fix impl dtype * fix impl dtype * rerun ci * update test * fix test * fix test * update fp16 test * fix impl * fix impl * fix impl * fix impl * fix impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
Update
paddle.searchsortedto support fp16 and bf16 data typerefer to: #64001 (comment)