-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the composition of minimum_double_grad #62342
Implement the composition of minimum_double_grad #62342
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
麻烦 @cyber-pioneer 卓哥也review一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加一下二阶组合单测
} else { | ||
grad_out_grad = nullptr; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的else分支可以删除,不会出现grad_x_grad和grad_y_grad同时不存在的情况
Sorry to inform you that a0b98f9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… minimum_double_grad update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for YAML
PR types
Others
PR changes
Others
Description
实现minimum的二阶微分组合,测试代码为:
@HydrogenSulfate