-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR AMP]Adapt auto_cast api for PIR AMP #61859
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
… adapt-auto_cast-api
… adapt-auto_cast-api
… adapt-auto_cast-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# set amp op list | ||
original_white_list, original_black_list = core._get_amp_op_list() | ||
core._set_amp_op_list(_white_list, _black_list) | ||
# set amp dtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是不是没有支持动态图下的master_grad
功能?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
动态图的master_grad
是通过hook实现的,在pir下无法通过此方式实现。pir下的master_grad
将在其他API内实现~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
动态图的
master_grad
是通过hook实现的,在pir下无法通过此方式实现。pir下的master_grad
将在其他API内实现~
好的,这里最好写一个Note
或者Todo
.下个PR加上也可以
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的感谢~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
[PIR AMP]Adapt auto_cast api for PIR AMP
Pcard-67164