Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR AMP]Adapt auto_cast api for PIR AMP #61859

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Feb 20, 2024

PR types

Others

PR changes

Others

Description

[PIR AMP]Adapt auto_cast api for PIR AMP
Pcard-67164

Copy link

paddle-bot bot commented Feb 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# set amp op list
original_white_list, original_black_list = core._get_amp_op_list()
core._set_amp_op_list(_white_list, _black_list)
# set amp dtype
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是没有支持动态图下的master_grad功能?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

动态图的master_grad是通过hook实现的,在pir下无法通过此方式实现。pir下的master_grad将在其他API内实现~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

动态图的master_grad是通过hook实现的,在pir下无法通过此方式实现。pir下的master_grad将在其他API内实现~

好的,这里最好写一个Note或者Todo.下个PR加上也可以

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的感谢~

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f requested a review from zhangting2020 February 26, 2024 07:24
@0x45f 0x45f merged commit 5d07c26 into PaddlePaddle:develop Feb 27, 2024
30 checks passed
@0x45f 0x45f deleted the adapt-auto_cast-api branch February 27, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants