Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] B-1 Adapt div test_errors #61112

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jan 24, 2024

PR types

Others

PR changes

Others

Description

相关链接:

Copy link

paddle-bot bot commented Jan 24, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -506,16 +508,11 @@ def test_shape_with_batch_sizes(self):


class TestDivideOp(unittest.TestCase):
@test_with_pir_api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pir下不需要test_name了,这个测试case就不用test_with_pir_api装饰了吧。这里直接把原来pir的测试代码删掉吧~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -492,7 +493,8 @@ class TestElementwiseDivBroadcast(unittest.TestCase):
@test_with_pir_api
def test_shape_with_batch_sizes(self):
paddle.enable_static()
with base.program_guard(base.Program()):
main_program = base.Program()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
main_program = base.Program()
main_program = paddle.static.Program()

@@ -492,7 +493,8 @@ class TestElementwiseDivBroadcast(unittest.TestCase):
@test_with_pir_api
def test_shape_with_batch_sizes(self):
paddle.enable_static()
with base.program_guard(base.Program()):
main_program = base.Program()
with base.program_guard(main_program):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with base.program_guard(main_program):
with paddle.static.program_guard(main_program):

@0x45f 0x45f merged commit 5faccae into PaddlePaddle:develop Jan 30, 2024
30 checks passed
@gouzil gouzil deleted the test_errors_1 branch April 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants