Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] fix data_op backend for gpu pinned tensor #60357

Conversation

feifei-111
Copy link
Contributor

@feifei-111 feifei-111 commented Dec 26, 2023

PR types

Others

PR changes

Others

Description

if input tensor is a cuda pinned tensor, data_op will choose gpu device, however the tensor loaded is still in cpu (gpu pinned).
pd_op_to_kernel_pass will not add memcpy, the first kernel will use gpu pinned tensor as a gpu tensor, it is slow

PCard-66972

Copy link

paddle-bot bot commented Dec 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@feifei-111 feifei-111 changed the title [PIR] fix data_op device for gpu pinned tensor [PIR] fix data_op backend for gpu pinned tensor Dec 26, 2023
Copy link
Contributor

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2742195759 2742195759 merged commit 430894e into PaddlePaddle:develop Dec 27, 2023
29 checks passed
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
@feifei-111 feifei-111 deleted the fix_data_op_process_cuda_pinned_tensor branch February 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants