Optimize performance of advanced getitem #60254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
Pcard-66985
This PR optimize the advanced index
__getitem__
performance.For int tensor case: replacing the slow
broadcast_tensors
tobroadcast_shape
andexpand
. It will be much faster in case no need broadcast, and faster thanbroadcast_tensors
.For bool tensor case: replacing the
nonzero
+gather_nd
tomasked_select
since the latter one is much faster. Moreover, the all-dtype support is added for kernelMaskedSelect
andMaskedSelectedGrad