Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] do not patch rpath for libxpuapi.so #60028

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Dec 14, 2023

PR types

Others

PR changes

Others

Description

删除与“修改libxpuapi.sorpath”相关的脚本。

XPU的依赖库libxpuapi.so,自身的rpath信息为$ORIGIN,并且它所依赖的其它动态链接库,如libxpurt.so,和它本身在同一个目录中,因此不需要修改成$ORIGIN/

此外,执行patchelf命令会导致该动态链接库本身的md5sum校验和发生变化,在某些情况下不便于排查这个二进制文件具体是什么版本。

因此本PR删除了相关的脚本。

Copy link

paddle-bot bot commented Dec 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 14, 2023
Copy link
Contributor

@lj970926 lj970926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 545598a into PaddlePaddle:develop Dec 18, 2023
29 checks passed
HermitSun pushed a commit to HermitSun/Paddle that referenced this pull request Dec 21, 2023
@houj04 houj04 added the XPU label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers XPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants