Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix cycle gan unittest for pir api mode. #58999

Merged
merged 9 commits into from
Nov 16, 2023
Merged

[BugFix] Fix cycle gan unittest for pir api mode. #58999

merged 9 commits into from
Nov 16, 2023

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Nov 14, 2023 •
edited by SigureMo
Loading

PR types

Bug fixes

PR changes

Others

Description

Fix cycle gan unittest for pir api mode.
这个单侧错误的原因是：

  1. 前向输入同时也是no need buffer，也应该作为skip vars，否则输出tensor被析构了。
  2. 直接 m = paddle.jit.to_static(func)(x); m.backward() 的时候，Program被release了。正解应该是传入一个Program的shared ptr。【TODO：未完全修好】

PCard-66972

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@2742195759 2742195759 marked this pull request as draft November 15, 2023 06:25
@2742195759 2742195759 marked this pull request as ready for review November 15, 2023 07:47
SigureMo
SigureMo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 9fc81e6 into PaddlePaddle:develop Nov 16, 2023
28 checks passed
@SigureMo SigureMo mentioned this pull request Nov 16, 2023
Closed
@2742195759 2742195759 deleted the fix-cycle-gan branch November 16, 2023 07:22
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@2742195759 @SigureMo @SecretXV
[BugFix] Fix cycle gan unittest for pir api mode. (PaddlePaddle#58999)
e4e0a7f 
---------

Co-authored-by: SigureMo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2742195759 @SigureMo