Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate print into pir #58780

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Migrate print into pir #58780

merged 7 commits into from
Nov 20, 2023

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Nov 7, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将如下算子迁移升级至 pir,并更新单测

  • print(5/5)

同时开启了 index_put的全部单测(39/39)

@zrr1999 zrr1999 changed the title Pir print Migrate print into pir Nov 7, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Nov 7, 2023
python/paddle/static/nn/control_flow.py Outdated Show resolved Hide resolved
test/legacy_test/test_pir_print_op.py Outdated Show resolved Hide resolved
@0x45f
Copy link
Contributor

0x45f commented Nov 8, 2023

看报错还是program的问题,检查下program_guard和Program接口调用是不是有问题吧~

@zrr1999
Copy link
Member Author

zrr1999 commented Nov 9, 2023

看报错还是program的问题,检查下program_guard和Program接口调用是不是有问题吧~

好的,这部分已经修复了,刚刚解决了一下冲突要重新跑一下ci

Aurelius84
Aurelius84 previously approved these changes Nov 10, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0x45f
0x45f previously approved these changes Nov 10, 2023
YuanRisheng
YuanRisheng previously approved these changes Nov 10, 2023
test/legacy_test/test_pir_print_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_pir_print_op.py Outdated Show resolved Hide resolved
sunzhongkai588
sunzhongkai588 previously approved these changes Nov 10, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no doc changes

@0x45f
Copy link
Contributor

0x45f commented Nov 17, 2023

python/paddle/static/nn/control_flow.py 的代码风格检查没有过,需要pre-commit下~

@0x45f 0x45f merged commit abac31f into PaddlePaddle:develop Nov 20, 2023
28 checks passed
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants