Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.33】 reshape more dtype and test -part #58764

Merged
merged 3 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/paddle/tensor/manipulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -3734,7 +3734,7 @@ def reshape(x, shape, name=None):
- 3. Given a 3-D tensor x with a shape [2, 4, 6], and the target shape is [-1, 0, 3, 2], the reshape operator will transform x into a 4-D tensor with shape [2, 4, 3, 2] and leaving x's data unchanged. In this case, besides -1, 0 means the actual dimension value is going to be copied from the corresponding dimension of x.

Args:
x (Tensor): An N-D Tensor. The data type is ``float32``, ``float64``, ``int32``, ``int64`` or ``bool``
x (Tensor): An N-D Tensor. The data type is ``float16``, ``float32``, ``float64``, ``int16``, ``int32``, ``int64``, ``uint16``, ``int8``, ``uint8``, ``complex64``, ``complex128``, ``bfloat16`` or ``bool``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no official support for uint16, should delete uint16?

Copy link
Contributor Author

@megemini megemini Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle use bfloat16 to hold uint16, so no official support for uint16?

In [42]: x = paddle.to_tensor(123, dtype='uint16')

In [43]: x
Out[43]: 
Tensor(shape=[], dtype=bfloat16, place=Place(cpu), stop_gradient=True,
       123.)

In [46]: x = paddle.to_tensor(65535, dtype='uint16')

In [47]: x
Out[47]: 
Tensor(shape=[], dtype=bfloat16, place=Place(cpu), stop_gradient=True,
       65280.)

shape (list|tuple|Tensor): Define the target shape. At most one dimension of the target shape can be -1.
The data type is ``int32`` . If ``shape`` is a list or tuple, each element of it should be integer or Tensor with shape [].
If ``shape`` is an Tensor, it should be an 1-D Tensor .
Expand Down Expand Up @@ -3879,6 +3879,11 @@ def get_attr_shape(list_shape):
'int64',
'bool',
'uint16',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue of uint16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff41404

numpy not support bfloat16, numpy uint16 is paddle bfloat16, so bfloat16 should be removed from check_variable_and_dtype, and keep uint16:

python/paddle/tensor/manipulation.py

        check_variable_and_dtype(
            x,
            'x',
            [
                'float16',
                'float32',
                'float64',
                'int16',
                'int32',
                'int64',
                'bool',
                'uint16',
                'int8',
                'uint8',
                'complex64',
                'complex128',
            ],
            'reshape',
        )

But remove uint16 & keep bfloat6 in unittest:

test/legacy_test/test_reshape_op.py

    def _test_static_dtype(self):
        places = [paddle.CPUPlace()] + (
            [paddle.CUDAPlace(0)] if base.core.is_compiled_with_cuda() else []
        )

        dtypes = [
            'float16',
            'float32',
            'float64',
            'int16',
            'int32',
            'int64',
            'int8',
            'uint8',
            'complex64',
            'complex128',
            'bfloat16',
            'bool',
        ]
    ...

right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a historical issue with function check_variable_and_dtype, which temporarily use uint16 instead of bfloat16 in its parameters. We will make unified revisions in the future. So keep uint16 as parameter of check_variable_and_dtype in python/paddle/tensor/manipulation.py temporarily and use bfloat16 instead of uint16 in unittest

'int8',
'uint8',
'complex64',
'complex128',
'bfloat16',
],
'reshape',
)
Expand Down
53 changes: 53 additions & 0 deletions test/legacy_test/test_reshape_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,9 +453,62 @@ def _test_api(self):
np.testing.assert_array_equal(res_3, input.reshape([5, 10]))
np.testing.assert_array_equal(res_4, input.reshape(shape))

def _test_static_dtype(self):
places = [paddle.CPUPlace()] + (
[paddle.CUDAPlace(0)] if base.core.is_compiled_with_cuda() else []
)

dtypes = [
'float16',
'float32',
'float64',
'int16',
'int32',
'int64',
'uint16',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue of uint16

'int8',
'uint8',
'complex64',
'complex128',
'bfloat16',
'bool',
]
for place in places:
for dtype in dtypes:
# core is not compiled with CUDA and not support the bfloat16
if (
dtype == 'bfloat16'
and not base.core.is_compiled_with_cuda()
):
continue

dtype_paddle = dtype
# numpy not support bfloat16, use uint16 instead
dtype_numpy = dtype if dtype != 'bfloat16' else 'uint16'

paddle.enable_static()
input = np.random.random([2, 25]).astype(dtype_numpy)
shape = [2, 5, 5]
main_prog = paddle.static.Program()
with paddle.static.program_guard(
main_prog, paddle.static.Program()
):
x = self.data(name="x", shape=[2, 25], dtype=dtype_paddle)
out_1 = self.reshape(x, shape)

exe = paddle.static.Executor(place=place)
res_1 = exe.run(
main_prog,
feed={"x": input},
fetch_list=[out_1],
)[0]

np.testing.assert_array_equal(res_1, input.reshape(shape))

def test_paddle_api(self):
self._set_paddle_api()
self._test_api()
self._test_static_dtype()

def test_imperative(self):
self._set_paddle_api()
Expand Down