Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cond create undefined var in global block #58065

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix cond create undefined var in global block #58065

merged 1 commit into from
Oct 17, 2023

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Oct 13, 2023 •
edited
Loading

PR types

Performance optimization

PR changes

Others

Description

fix cond create undefined var in global block
NOTE：
对于None的场景适配要更复杂点，还没有完全适配。比如

def func(b):
    a = None
    if b : 
        a = paddle.to_tensor([1,2])
    return

PCard-66972

@paddle-bot
Copy link

paddle-bot bot commented Oct 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

SigureMo
SigureMo approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@2742195759 2742195759 merged commit f83386b into PaddlePaddle:develop Oct 17, 2023
@2742195759 2742195759 deleted the fix-cond branch October 17, 2023 06:10
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
@2742195759 @wentaoyu
fix cond create undefined var in global block (PaddlePaddle#58065)
d2bd011
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
@2742195759 @jiahy0825
fix cond create undefined var in global block (PaddlePaddle#58065)
9d22cbd
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@2742195759
fix cond create undefined var in global block (PaddlePaddle#58065)
30830d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2742195759 @SigureMo @zhangbo9674