【Hackathon 5th No.13】为 Paddle 新增 signbit API #57882
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
能否完善下：paddle.sign 对 int 类型的支持 & less_than 对 int8 类型的支持，torch.signbit 对这几个类型都是支持的。 |
可以的，需要另外新开 pr 吗，还是同步和这个 pr 一起解决呢 |
可以新开两个PR，1个PR解决一个API的类型问题 |
好的没问题，顺便问一下可以算作快乐开源贡献吗哈哈哈哈 |
关联 PR 都属于黑客松的 |
好的 |
|
那目前就是先解决类型问题，类型问题合入后再合入 signbit api |
|
Sorry to inform you that 0ebade0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Co-authored-by: zachary sun <[email protected]>
Co-authored-by: zachary sun <[email protected]>
|
需要解决下CodeStyle问题 |
好的 已解决 |
|
PR-CI-Codestyle-Check 需要过一下 |
* refactor: added basic code of signbit * ✨ Refactor: added signbit API * 🦺 Fix: updated test case * ✏️ Fix: remove int8 support * ✨ Refactor: added int support to sign and less_than op * 🎨 Fix: updated code style * ✨ Refactor: added int8 support for less_than gpu kernel * Update test_sign_op.py * Update test_sign_op.py * Update sign_kernel.cc * Update compare_kernel.cc * Update compare_kernel.cu * ✏️ Fix: fixed indent error * ✏️ Fix: fixed type * ✏️ Fix: fixed typo * Refactor: added uint8 support to sign and updated test case * 🎨 Refactor: updated code style * 🚚 Refactor: moved uint8 support for sign to PaddlePaddle#59514 * 🚚 Refactor: moved uint8 support for sign to PaddlePaddle#59514 * ♻️ Refactor: added uint8 type * ✏️ Fix: updated test case * Fix: fixed intent error * Delete paddle/fluid/ir/dialect/paddle_dialect/ir/generated/pd_ops.parsed.yaml * Delete paddle/fluid/ir/dialect/paddle_dialect/ir/generated/pd_ops_backward.parsed.yaml * ♻️ Fixed commit * Fixed commit * 🎨 Fixed commit * ✏️ Fixed commit * 📝 Updated docs * updated docs * Update python/paddle/tensor/math.py Co-authored-by: zachary sun <[email protected]> * Update python/paddle/tensor/math.py Co-authored-by: zachary sun <[email protected]> * 🎨 Updated code style * ✏️ Fixed doc error * ✏️ Fixed doc error * 📝 Fixed doc error * 📝 Fixed doc * Update test_signbit.py * ✅ Updated test case * ✅ Updated test case * 🐛 Fixed logical error --------- Co-authored-by: zachary sun <[email protected]>
PR types
Others
PR changes
APIs
Description
Added signbit API to paddle.
文档 pr: PaddlePaddle/docs#6340
说明：
在实现过程中发现 paddle.sign 暂时不支持 int 类型的数据，故与 rfc 文档设想有所不同，【Hackathon 5th No.13】 为 Paddle 新增 signbit API community#650，问题修复 PR: 【Hackathon 5th No.13】【关联 PR】Added int support for sign -Part #58255
目前 paddle less_than 算子不支持 int8 和 int16 类型，问题修复 PR: 【Hackathon 5th No.13】【关联 PR】Added uint8&int8&int16 support for compare_kernel -part #58209
对 sign kernel 的 uint8 类型支持，问题修复 PR: 【Hackathon 5th No.13】【关联 PR】Added uint8 support for sign kernel -part #59514
【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 #57262