Executor need reasonable default value #5681
Conversation
| def __init__(self, places): | ||
| def __init__(self, places=None): | ||
| if places is None: | ||
| if core.is_compile_gpu(): |
There was a problem hiding this comment.
I think we need to detect at runtime whether a GPU is present. It's very likely a compiled GPU version runs on a CPU only machine.
paddle/pybind/pybind.cc
Outdated
| @@ -78,6 +78,14 @@ bool IsCompileGPU() { | |||
| #endif | |||
| } | |||
|
|
|||
| int GetCUDADeviceCount() { | |||
| #ifndef PADDLE_WITH_CUDA | |||
| return 0; | |||
There was a problem hiding this comment.
Maybe return -1 here to indicate error. Because the function name is GetCUDADeviceCount, if PADDLE_WITH_CUDA is OFF, the function can not do what its name suggests.
paddle/pybind/pybind.cc
Outdated
| @@ -497,6 +505,7 @@ All parameter, weight, gradient are variables in Paddle. | |||
| m.def("init_gflags", InitGflags); | |||
|
|
|||
| m.def("is_compile_gpu", IsCompileGPU); | |||
| m.def("get_cuda_device_count", GetCUDADeviceCount()); | |||
There was a problem hiding this comment.
Not familiar with Pybind, why it's a function invocation here? GetCUDADeviceCount(), rather than GetCUDADeviceCount?
There was a problem hiding this comment.
It is a bug. Thanks for pointing it out.
|
Thanks for the logic table! Very helpful. |
|
@reyoung Thanks for your comments. The reason for this PR is more of python API thing. We want to hide |
fix #5648
When using
exe = Executor(place=None), the logic is the following: