Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to False #56761

Merged
merged 18 commits into from
Oct 17, 2023
Merged

No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to False #56761

merged 18 commits into from
Oct 17, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Aug 29, 2023

PR types

Others

PR changes

Others

Description

Modify paddle.nn.utils.parameters_to_vector's stop_gradient to False

@paddle-bot
Copy link

paddle-bot bot commented Aug 29, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 29, 2023
@enkilee enkilee mentioned this pull request Aug 29, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 29, 2023
@enkilee
Copy link
Contributor Author

enkilee commented Aug 31, 2023

哪位大佬有空帮我rerun一下 PR-CI-WINDOWS，我没权限。

@luotao1
Copy link
Contributor

luotao1 commented Aug 31, 2023

已经帮你rerun了

@enkilee
Copy link
Contributor Author

enkilee commented Aug 31, 2023

谢谢大佬

@luotao1 luotao1 changed the title [WIP] No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to False No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to False Sep 5, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 18, 2023 

2023-09-14 13:52:31 test_utils_vector_to_parameters.py
2023-09-14 13:52:31 total bugs: 1
2023-09-14 13:52:31 [optimizer cases result]

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 28, 2023

Sorry to inform you that e52c890's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

zhwesky2010
zhwesky2010 reviewed Oct 12, 2023
View reviewed changes
python/paddle/nn/utils/transform_parameters.py Outdated Show resolved Hide resolved
python/paddle/nn/utils/transform_parameters.py Outdated Show resolved Hide resolved
python/paddle/nn/utils/transform_parameters.py Outdated Show resolved Hide resolved
python/paddle/nn/utils/transform_parameters.py Outdated Show resolved Hide resolved
python/paddle/nn/utils/transform_parameters.py Outdated Show resolved Hide resolved
@enkilee
Copy link
Contributor Author

enkilee commented Oct 13, 2023

@zhwesky2010 已改

@enkilee
Copy link
Contributor Author

enkilee commented Oct 16, 2023

@zhwesky2010 already done. thx.

zhwesky2010
zhwesky2010 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 94a81b2 into PaddlePaddle:develop Oct 17, 2023
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
@enkilee @wentaoyu
No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to …
20a0f98 
…False (PaddlePaddle#56761)

* fix

* fix

* fix

* CI

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
@enkilee @jiahy0825
No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to …
806a122 
…False (PaddlePaddle#56761)

* fix

* fix

* fix

* CI

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@enkilee
No.12 Modify paddle.nn.utils.parameters_to_vector's stop_gradient to …
d87a455 
…False (PaddlePaddle#56761)

* fix

* fix

* fix

* CI

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
@enkilee enkilee mentioned this pull request Dec 4, 2023
Closed
@enkilee enkilee deleted the modify-parameters_to_vector-stop_gradient branch December 19, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enkilee @luotao1 @zhwesky2010