Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Enhancement] No.5 support the auto default format of upsample #56471

Closed
wants to merge 5 commits into from

Conversation

Liyulingyue
Copy link
Contributor

PR types

Function optimization

PR changes

APIs

Description

#55883 No.5

@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Liyulingyue
Copy link
Contributor Author

@zhwesky2010 麻烦review一下~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 21, 2023
@luotao1 luotao1 changed the title [API Enhancement] support the auto default format of upsample [API Enhancement] No.5 support the auto default format of upsample Aug 21, 2023
@tink2123
Copy link
Contributor

感谢优化代码~ Paddle CI 会检查单测覆盖率,使代码的修改都有对应单元测试保证正确性,否则无法合入。
根据当前PR的CI log显示,单测覆盖率不足,因此麻烦对应修改单测文件:test_bilinear_interp_v2_op.py 以保证测试到新增改动。

@Liyulingyue
Copy link
Contributor Author

感谢优化代码~ Paddle CI 会检查单测覆盖率,使代码的修改都有对应单元测试保证正确性,否则无法合入。 根据当前PR的CI log显示,单测覆盖率不足,因此麻烦对应修改单测文件:test_bilinear_interp_v2_op.py 以保证测试到新增改动。

是不是应该改其他单测文件呀~?我感觉好像不应该是改interp?

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 30, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 30, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 5, 2023

image 需要修复下单测失败的问题

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 7, 2023

Sorry to inform you that d8f8bb5's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 25, 2023

Sorry to inform you that 3630731's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants