Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Enhancement] No.6 support single int input in UpsamplingNearest2D and UpsamplingBilinear2D #56470

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[API Enhancement] No.6 support single int input in UpsamplingNearest2D and UpsamplingBilinear2D #56470

merged 3 commits into from
Aug 28, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Aug 19, 2023 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Description

#55883 No.6
The docs will be modify after CI passing

@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 19, 2023
@Liyulingyue Liyulingyue mentioned this pull request Aug 19, 2023
Closed
@Liyulingyue
Copy link
Contributor Author

@zhwesky2010 麻烦review一下~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 21, 2023
@luotao1 luotao1 changed the title [API Enhancement] support single int input in UpsamplingNearest2D and UpsamplingBilinear2D [API Enhancement] No.6 support single int input in UpsamplingNearest2D and UpsamplingBilinear2D Aug 21, 2023
@tink2123
Copy link
Contributor

感谢优化代码～ Paddle CI 会检查单测覆盖率，使代码的修改都有对应单元测试保证正确性，否则无法合入。
根据当前PR的CI log显示，单测覆盖率不足，因此麻烦对应修改单测文件：test_bilinear_interp_v2_op.py 以保证测试到新增改动。

@Liyulingyue
Copy link
Contributor Author

感谢优化代码～ Paddle CI 会检查单测覆盖率，使代码的修改都有对应单元测试保证正确性，否则无法合入。 根据当前PR的CI log显示，单测覆盖率不足，因此麻烦对应修改单测文件：test_bilinear_interp_v2_op.py 以保证测试到新增改动。

是不是应该改其他单测文件呀~？我感觉好像不应该是改interp？

tink2123
tink2123 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@tink2123 tink2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liyulingyue Liyulingyue merged commit d0f1be5 into PaddlePaddle:develop Aug 28, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 28, 2023

@Liyulingyue 中英文文档都需要进行修改，请再提PR完善

This was referenced Aug 28, 2023
Merged
Merged
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@Liyulingyue @BeingGod
[API Enhancement] No.6 support single int input in UpsamplingNeares…
0c6b5c1 
…t2D and UpsamplingBilinear2D (PaddlePaddle#56470)

* enhance single int input in UpsamplingNearest2D and UpsamplingBilinear2D

* add unittest

* add unittest
@Liyulingyue Liyulingyue mentioned this pull request Nov 30, 2023
Closed
@Liyulingyue Liyulingyue deleted the APIEn1 branch January 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tink2123 tink2123 tink2123 approved these changes

Assignees

@luotao1 luotao1

@tink2123 tink2123

@zhwesky2010 zhwesky2010

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liyulingyue @tink2123 @luotao1 @zhwesky2010