Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][CINN] fix cpplint codestyle [readability/braces] #55049

Merged
merged 4 commits into from
Jul 2, 2023
Merged

[CodeStyle][CINN] fix cpplint codestyle [readability/braces] #55049

merged 4 commits into from
Jul 2, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Jun 30, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

fix CINN cpplint codestyle [readability/braces]

pre-commit run cpplint-cpp-source --all-files | grep "\[readability/braces\]"
paddle/utils/flat_hash_map.h:347:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
paddle/utils/flat_hash_map.h:611:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]

@paddle-bot
Copy link

paddle-bot bot commented Jun 30, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 30, 2023
@SigureMo SigureMo mentioned this pull request Jun 30, 2023
Closed
SigureMo
SigureMo approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 麻烦 rerun 下挂掉的两条流水线

@SigureMo SigureMo merged commit 3ad7842 into PaddlePaddle:develop Jul 2, 2023
@GreatV GreatV deleted the fix_cpplint_for_readability_braces branch July 2, 2023 14:55
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GreatV @SigureMo @luotao1