Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] fix unittest of shape op. #54323

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Jun 3, 2023

PR types

Bug fixes

PR changes

OPs

Description

shape算子在selected_rows下面缺少XPU的注册。之前没有踩上,而在这个PR #54221 修改了算子的注册方式,会导致XPU下面的单测跑不过。但是XPU单测脚本有bug(用另外的PR处理),导致明明单测挂了却没有拦住。
本PR追加了注册,让test_shape_op_xpu单测能正常跑过。

@paddle-bot
Copy link

paddle-bot bot commented Jun 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 3, 2023
Copy link
Contributor

@ZibinGuo ZibinGuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZibinGuo ZibinGuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZibinGuo ZibinGuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit f55eb06 into PaddlePaddle:develop Jun 5, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jun 5, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants