Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2 bug of eager #54041

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

wanghuancoder
Copy link
Contributor

@wanghuancoder wanghuancoder commented May 23, 2023

PR types

Bug fixes

PR changes

Others

Description

Pcard-64703
修复两个动态图bug:

  1. PyLayer在backward返回None后,grad_out添加了弄的Vector。在backward.cc中,如果Vector是空的会continue,导致None失效。修改方法为在Vector中加一个空的Tensor。
  2. backward.cc,如果反向初始多个Tensor为同一个Node的输入时,Node会被执行多次。需要去重。

@paddle-bot
Copy link

paddle-bot bot commented May 23, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 23, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 626ea80 into PaddlePaddle:develop May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants