Put files to platlib #5396
Merged
Put files to platlib #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
LGTM！
补充一些comment，方便更好的理解：
- https://www.python.org/dev/peps/pep-0427/#what-s-the-deal-with-purelib-vs-platlib： For example, Fedora installs pure Python packages to '/usr/lib/pythonX.Y/site-packages' and platform dependent packages to '/usr/lib64/pythonX.Y/site-packages'. 意思是说：python文件和平台依赖的文件，比如so，要分开装？
差不多，包含so的python包，都是和运行时环境相关的，所以要区别开。没有ext_modules那个参数，python会认为是纯py的包了
- 包含so的python包，现在是装到哪儿了
安装的位置，根据不同的系统应该是不同的。但只要在生成whl包的时候，放到platlib就能被识别
This was referenced Nov 6, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5392