[XPU] remove clip of c_softmax_with_cross_entropy op #53734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
QingshuChen
reviewed
May 12, 2023
| @@ -131,13 +131,6 @@ struct CSoftmaxWithCrossEntropyProcessGroupFunctor<phi::XPUContext, T> { | |||
| }; | |||
| phi::XPUElementwise<T, XPUType>( | |||
| dev_ctx, logits_2d, logits_max, axis, &softmax_2d, f); | |||
| ret = xpu::clip<XPUType>(dev_ctx.x_context(), | |||
There was a problem hiding this comment.
去掉clip会对结果有影响吗？
比如gpu kernel内部处理 了
There was a problem hiding this comment.
咨询过PaddlePaddle同学，回答说里面没有clip。
QingshuChen
approved these changes
May 12, 2023
QingshuChen
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Description
c_softmax_with_cross_entropy算子中，原先的GPU实现是带有一个clip操作的。因此在 [kunlun] prevent overflow in collective softmax_with_ce #52356 中，给XPU下的实现也增加了clip操作。clip操作：no value clip for parallel cross entropy #53547 ，因此本PR也跟着去掉这个操作。