【prim】add forward output for Silu grad signature #53632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
xiaoguoguo626807
changed the title
zyfncg
reviewed
May 11, 2023
Comment on lines
31
to
37
| #define DECLARE_ACTIVATION_GRAD_KERNEL_DEPXOUT(name) \ | ||
| template <typename T, typename Context> \ | ||
| void name##GradKernel(const Context& dev_ctx, \ | ||
| const DenseTensor& x, \ | ||
| const DenseTensor& out, \ | ||
| const DenseTensor& dout, \ | ||
| DenseTensor* dx); |
| @@ -32,6 +32,18 @@ namespace phi { | |||
| dev_ctx, &x, nullptr, &dout, dx, functor); \ | |||
| } | |||
|
|
|||
| #define DEFINE_CPU_ACTIVATION_GRAD_KERNEL_DEPXOUT(name, functor_class) \ | |||
| @@ -86,6 +86,18 @@ void ActivationGradGPUImpl(const Context& dev_ctx, | |||
| dev_ctx, &x, nullptr, &dout, dx, functor); \ | |||
| } | |||
|
|
|||
| #define DEFINE_GPU_ACTIVATION_GRAD_KERNEL_DEPXOUT(name, functor_class) \ | |||
| @@ -49,6 +49,18 @@ void ActivationGradXPUImpl(const Context& dev_ctx, | |||
| dev_ctx, &x, nullptr, &dout, dx, functor); \ | |||
| } | |||
|
|
|||
| #define DEFINE_XPU_ACTIVATION_GRAD_KERNEL_DEPXOUT(name, functor_class) \ | |||
zyfncg
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
others
Description
pcard-66975
修改silu_grad的yaml配置为silu_grad(x, out, out_grad, x_grad)， 增加前向的输出为输入，以避免一阶组合算子在计算sigmod后进行自动微分，使得数值不稳定。