Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inference Zero-Dim][trt]Unary operation support 0d #53506

Merged
merged 5 commits into from
May 8, 2023

Conversation

zhangjun
Copy link
Contributor

@zhangjun zhangjun commented May 4, 2023

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented May 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 4, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check why PR#53383 can pass CI.

+ runtime_version[2] * 10
< 8600
and self.dims == 0
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A common function can be extracted to calculate TensorRT version number
  2. In line 174, use ver = paddle_infer.get_trt_compile_version() to get version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A common function can be extracted to calculate TensorRT version number
  2. In line 174, use ver = paddle_infer.get_trt_compile_version() to get version

When the OP behavior is inconsistent among different TensorRT versions, using the runtime version is more appropriate than the compiled version, making it easier to test multiple versions.

@@ -60,6 +60,7 @@ def generate_int_input(dims, batch, attrs: List[Dict[str, Any]]):
"sin",
"cos",
"tan",
"tanh",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remove tanh, where to test it?

Copy link
Contributor Author

@zhangjun zhangjun May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remove tanh, where to test it?

move tanhfrom test_trt_convert_activation.py to test_trt_convert_unary.py.

@zhangjun zhangjun changed the title [inference][trt]Fix Unary operation do not support 0d when TRT < 8.6 [inference][trt]Unary operation do not support 0d May 5, 2023
@zhangjun zhangjun changed the title [inference][trt]Unary operation do not support 0d [inference][trt]Unary operation support 0d May 5, 2023
@zhangjun zhangjun merged commit 10f9249 into PaddlePaddle:develop May 8, 2023
@zhwesky2010 zhwesky2010 changed the title [inference][trt]Unary operation support 0d [inference Zero-Dim][trt]Unary operation support 0d May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants