Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cmake3.16 to 3.18 #53288

Merged

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Apr 24, 2023

PR types

Others

PR changes

Others

Description

Pcard-67010
将cmake从3.16升级到3.18,方便后续c++14升级到17的工作,c++17需要cmake版本大于等于3.18

@paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@risemeup1 risemeup1 force-pushed the update_cmake3.16_to_cmake3.18 branch from 3786945 to cc50bfb Compare April 26, 2023 06:25
Copy link
Contributor

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 没有问题,但ROCM、Kunlun镜像可能需要手动升级cmake版本,才能支持c++17

@risemeup1 risemeup1 merged commit 166964b into PaddlePaddle:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants