Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parameter check error in rmsprop_kernel_xpu. #52866

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ZibinGuo
Copy link
Contributor

@ZibinGuo ZibinGuo commented Apr 13, 2023

PR types

Bug fixes

PR changes

Others

Describe

某些特殊的情况会导致learning_rate参数的meta的数据为:meta: is_scalar = 0, dims = , dtype = float32, layout = NCHW, lod = {}, offset = 0,但由于本身是标量,所以还是有值的,且cpu、gpu的kernel也不会对该参数的dim做检查,故去除此参数检查限制。

@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen QingshuChen merged commit 9dc7e5e into PaddlePaddle:develop Apr 13, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants