Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static graph code-gen for yolo_box #52714

Merged
merged 7 commits into from
Apr 13, 2023

Conversation

sanbuphy
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

#51842

@paddle-bot
Copy link

paddle-bot bot commented Apr 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 10, 2023
heavyrain-lzy
heavyrain-lzy previously approved these changes Apr 11, 2023
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavyrain-lzy
Copy link
Contributor

@chenwhql 为了能够代码自动生成,为class_num添加了默认值,麻烦review一下

@heavyrain-lzy
Copy link
Contributor

请rerun相关CI

@heavyrain-lzy
Copy link
Contributor

static-check可以豁免一下@luotao1

@heavyrain-lzy
Copy link
Contributor

请return相关CI

@sanbuphy
Copy link
Contributor Author

@heavyrain-lzy 多次return kunlun还是挂了,请求支援

detection_library(generate_proposals_v2_op SRCS generate_proposals_v2_op.cc)
else()
detection_library(iou_similarity_op SRCS iou_similarity_op.cc
iou_similarity_op.cu)
detection_library(prior_box_op SRCS prior_box_op.cc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只删除yolo_box_op.cc相关的,这句不要删除呀

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 9bdf7f0 into PaddlePaddle:develop Apr 13, 2023
@sanbuphy sanbuphy deleted the yoloboxop branch April 13, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants