Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the forward's stack when backward op has nan/inf and FLAGS_check_nan_inf_level = 0 #52639

Merged
merged 9 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,12 @@ paddle::Tensor add_n_ad_func(const std::vector<paddle::Tensor>& x) {
VLOG(3) << "Final State Running: "
<< "add_n_ad_func";
auto api_result = paddle::experimental::add_n(x);

std::string forward_trace = "";
// Check NaN and Inf if needed
if (FLAGS_check_nan_inf) {
egr::CheckTensorHasNanOrInf("add_n", api_result);
forward_trace = egr::Controller::Instance().GetPythonStack();
}

// Get Outputs
Expand All @@ -83,6 +86,12 @@ paddle::Tensor add_n_ad_func(const std::vector<paddle::Tensor>& x) {
// Node Construction
auto grad_node =
std::shared_ptr<AddNGradNodeFinal>(new AddNGradNodeFinal(1, 1));

// Set forward's stack
if (FLAGS_check_nan_inf) {
grad_node->SetForwardTrace(forward_trace);
}

// SetAttributes if needed

// Set TensorWrappers for Forward Inputs if needed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,11 @@ paddle::Tensor conv2d_ad_func(const paddle::Tensor& input,
dilations,
groups,
data_format);
std::string forward_trace = "";
// Check NaN and Inf if needed
if (FLAGS_check_nan_inf) {
egr::CheckTensorHasNanOrInf("conv2d", api_result);
forward_trace = egr::Controller::Instance().GetPythonStack();
}

// Get Outputs
Expand All @@ -138,6 +140,12 @@ paddle::Tensor conv2d_ad_func(const paddle::Tensor& input,
// Node Construction
auto grad_node =
std::shared_ptr<Conv2dGradNodeFinal>(new Conv2dGradNodeFinal(1, 2));

// Set forward's stack
if (FLAGS_check_nan_inf) {
grad_node->SetForwardTrace(forward_trace);
}

// SetAttributes if needed
grad_node->SetAttributestrides(strides);
grad_node->SetAttributepaddings(paddings);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,11 @@ sync_batch_norm__ad_func(const paddle::Tensor& x,
data_layout,
use_global_stats,
trainable_statistics);
std::string forward_trace = "";
// Check NaN and Inf if needed
if (FLAGS_check_nan_inf) {
egr::CheckTensorHasNanOrInf("sync_batch_norm_", api_result);
forward_trace = egr::Controller::Instance().GetPythonStack();
}

// Get Outputs
Expand Down Expand Up @@ -226,6 +228,12 @@ sync_batch_norm__ad_func(const paddle::Tensor& x,
// Node Construction
auto grad_node =
std::shared_ptr<SyncBatchNormGradNode>(new SyncBatchNormGradNode(6, 5));

// Set forward's stack
if (FLAGS_check_nan_inf) {
grad_node->SetForwardTrace(forward_trace);
}

egr::Controller::Instance().PushBackForceSequentialNodes(grad_node.get());
// SetAttributes if needed
grad_node->SetAttributemomentum(momentum);
Expand Down
6 changes: 6 additions & 0 deletions paddle/fluid/eager/api/utils/global_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ class Controller {

void EnableLayoutAutoTune() { tracer_->EnableLayoutAutoTune(); }

void SetPythonStack(std::string stack_str) {
tracer_->SetPythonStack(stack_str);
}

std::string GetPythonStack() { return tracer_->GetPythonStack(); }

bool HasGrad() const { return tracer_->HasGrad(); }
void SetHasGrad(bool has_grad) { tracer_->SetHasGrad(has_grad); }
std::string GenerateUniqueName(std::string key = "eager_in_tmp") {
Expand Down
34 changes: 30 additions & 4 deletions paddle/fluid/eager/auto_code_generator/generator/eager_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,10 @@ class {} : public egr::GradNodeBase {{

// Node Construction
{}
// Set for forward trace
if (FLAGS_check_nan_inf) {{
{}
}}
// SetAttributes if needed
{}
// Set TensorWrappers for Forward Inputs if needed
Expand Down Expand Up @@ -484,7 +488,25 @@ class {} : public egr::GradNodeBase {{
}}
}}"""

CHECK_NAN_AND_INF_TEMPLATE = """ if (FLAGS_check_nan_inf) {{ egr::CheckTensorHasNanOrInf("{}", {}); }}
CHECK_NAN_AND_INF_TEMPLATE_FORWARD = """
std::string forward_trace ="";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以不使用临时变量减少下平凡的构造和析构开销

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的 我下个PR统一修改

if (FLAGS_check_nan_inf) {{
egr::CheckTensorHasNanOrInf("{}", {});
forward_trace = egr::Controller::Instance().GetPythonStack();
}}
"""

CHECK_NAN_AND_INF_TEMPLATE_BACKWARD = """
if (FLAGS_check_nan_inf) {{
try{{
egr::CheckTensorHasNanOrInf("{}", {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forward_trace可以直接传入CheckTensorHasNanOrInf,在CheckTensorHasNanOrInf里面打印?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那样就需要修改CheckTensorHasNanOrInf了,代码改的比较多了

Copy link
Contributor

@Xreki Xreki Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckTensorHasNanOrInf是合理的啊,因为打印调用栈本身就是CheckTensorHasNanOrInf功能的一部分,后面静态图也能服用部分逻辑,可以后续PR再考虑。

}} catch(...) {{
LOG(WARNING) << "There are nan/inf in ({})";
auto forward_trace = GetForwardTrace();
std::cout<<forward_trace<<std::endl;
std::rethrow_exception(std::current_exception());
}}
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意字符串模板中的代码格式,另外为啥要用两个花括号?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是自动代码生成需要用两层花括号

"""

inplace_optional_out_type_map = {
Expand Down Expand Up @@ -1047,11 +1069,15 @@ def GenerateNodeCreationCodes(self, for_backward=False):

node_event_name = forward_api_name + " node_creation"
node_creation_event_str = f"{indent}paddle::platform::RecordEvent node_creation_record_event(\"{node_event_name}\", paddle::platform::TracerEventType::OperatorInner, 1);\n"
set_forward_trace = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否设置FLAGS_check_nan_inf为false时不设置?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的,后续和上面的临时变量问题统一修改

f"{indent} grad_node->SetForwardTrace(forward_trace);"
)
if not for_backward:
self.node_creation_str = FORWARD_BODY_TEMPLATE.format(
node_creation_event_str,
pass_stop_gradient_args_str,
node_construction_str,
set_forward_trace,
set_attributes_str,
set_input_tensor_wrappers_str,
set_grad_out_meta_str,
Expand Down Expand Up @@ -1426,7 +1452,7 @@ def GenerateForwardDefinitionAndDeclaration(self, is_inplaced):
)

# Check Nan and Inf
check_nan_inf_str = CHECK_NAN_AND_INF_TEMPLATE.format(
check_nan_inf_str = CHECK_NAN_AND_INF_TEMPLATE_FORWARD.format(
function_name, "api_result"
)

Expand Down Expand Up @@ -2320,8 +2346,8 @@ def GenerateNodeDefinition(
{indent}{grad_api_namespace}{backward_api_name}({grad_api_args_str});"""

# Check Nan and Inf
check_nan_inf_str = CHECK_NAN_AND_INF_TEMPLATE.format(
backward_api_name, "returns"
check_nan_inf_str = CHECK_NAN_AND_INF_TEMPLATE_BACKWARD.format(
backward_api_name, "returns", backward_api_name
)

# Prepare for Node Creation if Necessary
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ def FindParsingFunctionFromAttributeType(atype):
NOAMP_DYGRAPH_FUNCTION_TEMPLATE = "decltype({}({})) out = {}({});"


FUNCTION_SET_DEVICE_TEMPLATE = """{} if (paddle::platform::is_gpu_place(place)) {{
FUNCTION_SET_DEVICE_TEMPLATE = """{}
LOG(INFO)<<"this is SetPythonStack";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个模板是用于哪里的?LOG(INFO)会一直输出吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的 这个我下个PR再修改

SetPythonStack();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要加if (FLAGS_check_nan_inf)判断来限制一下吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要,这个调用里面我加了判断

if (paddle::platform::is_gpu_place(place)) {{
#if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP)
phi::backends::gpu::SetDeviceId(place.device);
VLOG(4) <<"CurrentDeviceId: " << phi::backends::gpu::GetCurrentDeviceId() << " from " << (int)place.device;
Expand Down Expand Up @@ -170,7 +173,6 @@ def FindParsingFunctionFromAttributeType(atype):
#include "paddle/fluid/pybind/eager.h"
#include "paddle/fluid/eager/amp_utils.h"
#include "paddle/fluid/eager/eager_amp_auto_cast.h"

namespace paddle {{
namespace pybind {{

Expand Down
6 changes: 6 additions & 0 deletions paddle/fluid/eager/grad_node_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,10 @@ class GradNodeBase {
is_tensor_wrappers_cleared_ = is_tensor_wrappers_cleared;
}

void SetForwardTrace(std::string trace) { forward_trace_ = trace; }

std::string GetForwardTrace() { return forward_trace_; }

private:
// bwd_out_meta_ is used to record Grad output info for backward
paddle::small_vector<std::vector<GradSlotMeta>, kSlotSmallVectorSize>
Expand All @@ -317,6 +321,8 @@ class GradNodeBase {
bool need_complex_to_real_ = false;

bool is_tensor_wrappers_cleared_ = false;
// The trace of forward function
std::string forward_trace_ = "";
};

} // namespace egr
1 change: 1 addition & 0 deletions paddle/fluid/imperative/tracer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ DECLARE_string(tracer_mkldnn_ops_off);

namespace paddle {
namespace imperative {
thread_local std::string Tracer::python_stack_ = "";

thread_local bool Tracer::enable_program_desc_tracing_ = false;

Expand Down
4 changes: 3 additions & 1 deletion paddle/fluid/imperative/tracer.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ class Tracer {
use_layout_autotune_ = false;
return false;
}

void SetPythonStack(std::string stack_str) { python_stack_ = stack_str; }
std::string GetPythonStack() { return python_stack_; }
phi::KernelSignature GetExpectedKernelSignature(
const std::string& type,
const NameTensorMap& ins,
Expand All @@ -215,6 +216,7 @@ class Tracer {
std::unique_ptr<UniqueNameGenerator> generator_;
platform::Place expected_place_;
GarbageCollectorMap gcs_;
static thread_local std::string python_stack_;
static thread_local bool enable_program_desc_tracing_;
static thread_local bool use_layout_autotune_;
static thread_local bool has_grad_;
Expand Down
16 changes: 16 additions & 0 deletions paddle/fluid/pybind/eager_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ limitations under the License. */
#include "paddle/phi/common/data_type.h"
#include "paddle/phi/core/compat/convert_utils.h"
#include "paddle/phi/core/dense_tensor.h"
DECLARE_bool(check_nan_inf);

namespace paddle {
namespace pybind {
Expand Down Expand Up @@ -216,6 +217,21 @@ std::shared_ptr<imperative::VarBase> CastPyArg2VarBase(PyObject* obj,
return py::cast<std::shared_ptr<imperative::VarBase>>(obj);
}

void SetPythonStack() {
if (FLAGS_check_nan_inf) {
pybind11::gil_scoped_acquire gil;
PyObject* mod = PyImport_ImportModule("traceback");
PyObject* traceback_list = PyObject_CallMethod(mod, "format_stack", "");
std::string str = "";
for (Py_ssize_t i = 0; i < PyList_Size(traceback_list); i++) {
PyObject* line = PyList_GetItem(traceback_list, i);
str += py::str(PyUnicode_AsUTF8(line));
}
std::string last = str + egr::Controller::Instance().GetPythonStack();
egr::Controller::Instance().SetPythonStack(last);
}
}

std::shared_ptr<jit::Function> CastPyArg2JitFunction(PyObject* obj,
ssize_t arg_pos) {
if (PyObject_IsInstance(obj,
Expand Down
1 change: 1 addition & 0 deletions paddle/fluid/pybind/eager_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ std::vector<std::string> CastPyArg2VectorOfString(PyObject* obj,
ssize_t arg_pos);
std::shared_ptr<jit::Function> CastPyArg2JitFunction(PyObject* obj,
ssize_t arg_pos);
void SetPythonStack();

PyObject* ToPyObject(int value);
PyObject* ToPyObject(uint32_t value);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


import paddle


def main():
paddle.set_flags({"FLAGS_check_nan_inf": 1, "FLAGS_check_nan_inf_level": 0})
cpu_place = paddle.CPUPlace()
x = paddle.to_tensor([1, 0.0, 3], stop_gradient=False, place=cpu_place)
y = paddle.to_tensor([0.2, 0.0, 0.5], place=cpu_place)
z = paddle.pow(x, y)
paddle.autograd.backward([z])


if __name__ == "__main__":
main()
26 changes: 26 additions & 0 deletions python/paddle/fluid/tests/unittests/test_nan_inf.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ def setUp(self):


class TestNanInfCheckResult(unittest.TestCase):
def setUp(self):
self._python_interp = sys.executable
if os.getenv('WITH_COVERAGE', 'OFF') == 'ON':
self._python_interp += " -m coverage run --branch -p"

self.env = os.environ.copy()

def generate_inputs(self, shape, dtype="float32"):
data = np.random.random(size=shape).astype(dtype)
# [-10, 10)
Expand Down Expand Up @@ -141,6 +148,25 @@ def _check_num_nan_inf(use_cuda):
if paddle.fluid.core.is_compiled_with_cuda():
_check_num_nan_inf(use_cuda=True)

def test_check_stack(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个测试其实没有必要再费劲加到这个单测里面了。之所以构造这么一个复杂的测试方式,是因为之前CUDA抛出的异常捕获不到。调用栈报错,应该可以直接用try ... except捕获到。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不行呀,前向的调用栈是print出来的,无法try... except捕获

self._python_interp += " check_nan_inf_backward_stack.py"
cmd = self._python_interp
proc = subprocess.Popen(
cmd.split(" "),
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
env=self.env,
)

out, err = proc.communicate()
returncode = proc.returncode

print(out)
print(err)

# in python3, type(out+err) is 'bytes', need use encode
assert (out + err).find(b' z = paddle.pow(x, y)') != -1

def check_nan_inf_level(self, use_cuda, dtype):
shape = [8, 8]
x_np, y_np = self.generate_inputs(shape, dtype)
Expand Down