【Hackathon No57】 add fp16 & bf16 for flip, fp16 for gaussian #52380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Vvsmile
reviewed
Apr 3, 2023
| @@ -74,9 +74,21 @@ def setUp(self): | |||
| self.op_type = 'flip' | |||
| self.python_api = paddle.tensor.flip | |||
| self.init_test_case() | |||
| self.inputs = {'X': np.random.random(self.in_shape).astype('float64')} | |||
| self.input = np.random.random(self.in_shape).astype(self.dtype) | |||
There was a problem hiding this comment.
在使用self.dtype之前没有调用init_dtype函数
Vvsmile
reviewed
Apr 3, 2023
| self.inputs = {'X': self.input.astype(self.dtype)} | ||
| output = output.astype(self.dtype) | ||
|
|
||
| self.outputs = {'Out': output} |
There was a problem hiding this comment.
BF16的情况下，outputs部分应当也是用convert_float_to_uint16做类型转换
|
修改好PR描述后可以重新Close-reopen 一下该PR，让他通过一下CheckPRTemplate 检测 |
Difers
force-pushed
the
add_fp_bf_4_flip_gaussian
branch
from
3a15ca4
to
cab8b6b
Compare
Difers
force-pushed
the
add_fp_bf_4_flip_gaussian
branch
from
cab8b6b
to
9e10224
Compare
|
done,辛苦再review下~ |
|
LGTM |
ZzSean
reviewed
Apr 6, 2023
| self.init_attrs() | ||
| self.outputs = {'Out': self.calc_ref_res()} | ||
| self.init_dtype() | ||
| self.input = np.random.random(self.in_shape).astype(self.dtype) |
There was a problem hiding this comment.
当dtype==np.uint16时候self.dtype需要改成np.float32，可以与下面类似，搞个分支判断
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
gaussian， 完善FP16单测，确认误差阈值设置是否合理
flip， 增加BF16支持，完善FP16, BF16单测