Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scatter composite rule. #52005

Merged
merged 8 commits into from
Mar 30, 2023
Merged

add scatter composite rule. #52005

merged 8 commits into from
Mar 30, 2023

Conversation

zxcd
Copy link
Contributor

@zxcd zxcd commented Mar 22, 2023 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

Add scatter composite rule.

@paddle-bot
Copy link

paddle-bot bot commented Mar 22, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cxxly
Copy link
Contributor

cxxly commented Mar 28, 2023

修复codestyle

cxxly
cxxly previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for composite_backward_api.h

zyfncg
zyfncg previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for yaml change

zhiqiu
zhiqiu previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for UT

@zxcd zxcd dismissed stale reviews from zhiqiu, zyfncg, and cxxly via b6c20bf March 29, 2023 09:55
@zxcd zxcd requested review from cxxly and removed request for cxxly March 30, 2023 02:23
cxxly
cxxly approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Charles-hit Charles-hit merged commit e16eb22 into PaddlePaddle:develop Mar 30, 2023
@zxcd zxcd deleted the scatter branch December 14, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 left review comments

@Charles-hit Charles-hit Charles-hit approved these changes

@zyfncg zyfncg zyfncg approved these changes

@cxxly cxxly cxxly approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zxcd @cxxly @zhiqiu @zyfncg @Charles-hit @xiaoguoguo626807