Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greater_equal API for fp16 #51098

Merged
merged 4 commits into from
Mar 6, 2023
Merged

greater_equal API for fp16 #51098

merged 4 commits into from
Mar 6, 2023

Conversation

Taylor-Layrose
Copy link
Contributor

@Taylor-Layrose Taylor-Layrose commented Mar 2, 2023 •
edited by luotao1
Loading

PR types

Bug fixes

PR changes

APIs

Describe

add float16 to greater_equal

@paddle-bot
Copy link

paddle-bot bot commented Mar 2, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 2, 2023
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@luotao1 luotao1 mentioned this pull request Mar 2, 2023
Closed
zhangting2020
zhangting2020 reviewed Mar 2, 2023
View reviewed changes
python/paddle/fluid/tests/unittests/test_greater_equal_op.py
exe = fluid.Executor(place)
(res,) = exe.run(fetch_list=[out])
self.assertEqual((res == np.array([True, True])).all(), True)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前不推荐使用fluid下的API，建议：
fluid.program_guard -> paddle.static.program_guard
fluid.Executor -> paddle.static.Executor
fluid.Program() -> paddle.static.Program()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已经改了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码风格也改好了，请问CI-Static-Check测试是需要管理员处理才能通过嘛

@zhangting2020
Copy link
Contributor

关注下PR-CI-Codestyle-Check的提示，修改代码风格

@Liyulingyue
Copy link
Contributor

Liyulingyue commented Mar 2, 2023 •
edited
Loading

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

点击上面的黄色的块块，签署一下贡献者协议~这样才能通过CI检查

@Liyulingyue
Copy link
Contributor

Liyulingyue commented Mar 2, 2023 •
edited
Loading

请参考https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/code_contributing_path_cn.html 或者在aistudio搜索教程，安装pre-commit以自动修改你的代码通过CI-codestyle检查~

直接参考PR-CI-Codestyle-Check旁边Details页面中的提示修改也是可以的~

@Taylor-Layrose
Copy link
Contributor Author

image
CI-Static-Check测试是需要管理员处理才能通过嘛

@Taylor-Layrose
Copy link
Contributor Author

@zhangting2020
image

CI-Static-Check测试是需要管理员处理才能通过嘛

@Taylor-Layrose
Copy link
Contributor Author

@luotao1
image
请问CI-Static-Check测试是需要管理员处理才能通过嘛，除了这个之外，我其他的CI测试都通过了。

@luotao1 luotao1 merged commit ad92a5c into PaddlePaddle:develop Mar 6, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 6, 2023

hi, @Taylor-Layrose

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 [email protected]，我们会邀请你加入~

@luotao1
Copy link
Contributor

luotao1 commented Mar 6, 2023 •
edited
Loading

中文文档使用如下 PR：

@luotao1 luotao1 mentioned this pull request Mar 6, 2023
Closed
@Taylor-Layrose Taylor-Layrose mentioned this pull request Mar 7, 2023
Merged
@Taylor-Layrose
Copy link
Contributor Author

中文文档使用如下 PR：

@luotao1 中文文档提交pr PaddlePaddle/docs#5683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

Assignees

@luotao1 luotao1

@zhangting2020 zhangting2020

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Taylor-Layrose @CLAassistant @zhangting2020 @Liyulingyue @luotao1