-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] Type system stage3: add class Dialect #50959
[IR] Type system stage3: add class Dialect #50959
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
paddle/ir/type_base.h
Outdated
/// | ||
/// \return The dialect this type was registered to. | ||
/// | ||
Dialect &dialect() const { return const_cast<Dialect &>(dialect_); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议返回const Dialect&, 或者将成员变量改为 Dialect&。 目前的这种操作太不合理。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我完善一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Describe
Pcard-67160
1. PR 主要内容:
本 PR 添加了 Dialect 数据结构,Dialect 的作用是:Type 注册进 Dialect、Dialect 注册进 IrContext。核心文件如下:
2. 应用示例:
3. Todo: